persist: log full error chain for indeterminate compare_and_append er… - #37901
Merged
peterdukelarsen merged 1 commit intoAug 17, 2026
Merged
Conversation
…rors The compare_and_append retry loop logged the Indeterminate error with its plain Display. A tokio_postgres error renders as just "db error" there, because the underlying DbError (SQLSTATE, message, detail, hint) is only reachable through the source chain. Format with display_with_causes(), matching retry_external, so the cause chain reaches the log line. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
petrosagg
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Unable to see detailed error about why persist failed to compare_and_append.
"compare_and_append received an indeterminate error, retrying in 16s: indeterminate: db error"
Description
Format with display_with_causes(), matching retry_external, so the cause chain reaches the log line.
Verification